feat: move non-subcircuit group #431
Conversation
There was a problem hiding this comment.
Not a bad implementation but i have a slightly different one in mind that i think coupd be better- each parent returns it’s “transform” to its children (something like _computeSchematicTransform), this is better than offsetting in a later render phase.
I can give it a try shortly, feel free to take a stab!
|
Basically _computeSchematicPositionBeforeLayout should return the correct schematic position for children (offset by all parent groups) |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
imrishabh18
force-pushed
the
feat/non-subcircuit-group
branch
from
1965697 to
6483bf8
Compare
|
@seveibar This is what you mean't by having another function to compute the offset for the decedent's? |
| @@ -308,18 +308,48 @@ export class Group<Props extends z.ZodType<any, any, any> = typeof groupProps> | |||
| } | |||
| } | |||
|
|
|||
| _computeSchematicPositionBeforeLayout(): void { | |||
| const { db } = this.root! | |||
There was a problem hiding this comment.
This method shouldnt mutate, never mutate db unless you're definitely inside a render phase and the name of the method makes sense to mutate
|
@imrishabh18 i'll record a video for you |
/close #390