Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

561 add home breadcrumb #621

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

561 add home breadcrumb #621

wants to merge 5 commits into from

Conversation

bmblumenfeld
Copy link
Contributor

Fixes #561

Proposed changes

  • Refactored RouteScreen component --> split out all breadcrumb logic to its own component and tidied up a bit.
  • Added a homeLink to the breadcrumb bar
  • Removed the back icon that replaced the hamburger menu during route navigation. This was made possible by adding home link to breadcrumb bar

Steps to test

  • Select a route
  • Hamburger menu should remain and a home link should be added to the beginning of the breadcrumb bar

Screenshot

https://cl.ly/05aefe40f85e

@youngj
Copy link
Contributor

youngj commented Apr 1, 2020

This conflicts with #607 - could you review that PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exxonvaldez exxonvaldez Awaiting requested review from exxonvaldez exxonvaldez is a code owner

@akgupta89 akgupta89 Awaiting requested review from akgupta89 akgupta89 is a code owner

@ckrajewski ckrajewski Awaiting requested review from ckrajewski ckrajewski is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Back Button into Transit Agency, add to breadcrumb
3 participants
@bmblumenfeld @youngj @benmyagi