🏷️ global import common types #56

trydofor · Oct 17, 2024 · cc5e9a3 · cc5e9a3
1 parent d757d3b
commit cc5e9a3
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 11 deletions.
diff --git a/.changeset/large-bottles-own.md b/.changeset/large-bottles-own.md
@@ -0,0 +1,6 @@
+---
+"@fessional/razor-common": patch
+"@fessional/razor-mobile": patch
+---
+
+🏷️ global import common types #56
diff --git a/layers/common/nuxt.config.ts b/layers/common/nuxt.config.ts
@@ -22,8 +22,5 @@ export default defineNuxtConfig({
   },
   typescript: {
     typeCheck: true,
-    tsConfig: {
-      include: ['./types/*'],
-    },
   },
 });
diff --git a/layers/common/package.json b/layers/common/package.json
@@ -36,4 +36,4 @@
     "@vueuse/nuxt": "catalog:common",
     "vue": "catalog:common"
   }
-}
+}
diff --git a/layers/common/test/typed-fetching.test.ts b/layers/common/test/typed-fetching.test.ts
@@ -1,6 +1,5 @@
 import { describe, it, expect, vi } from 'vitest';
 import { fetchingData, fetchingDataAsync } from '../utils/typed-fetching';
-import type { DataResult } from '../types/common';
 
 describe('fetchingData', () => {
   it('should call loading with true and false', () => {

diff --git a/layers/common/types/common.d.ts → layers/common/types/common.global.d.ts b/layers/common/types/common.d.ts → layers/common/types/common.global.d.ts
@@ -1,4 +1,4 @@
-export interface DataResult<T> {
+interface DataResult<T> {
   success: boolean;
   data?: T;
   message?: string;

diff --git a/layers/common/utils/typed-fetching.ts b/layers/common/utils/typed-fetching.ts
@@ -1,6 +1,4 @@
-import type { DataResult } from '../types/common';
-
-export type TypedFetchingOptions = {
+export type TypedFetchingOptions = {
   /**
    * @param status - true if loading, false if done
    */

diff --git a/layers/mobile/test/ionic-fetching.test.ts b/layers/mobile/test/ionic-fetching.test.ts
@@ -1,7 +1,6 @@
 import { describe, it, expect, vi, beforeEach } from 'vitest';
 import { loadingController, alertController } from '@ionic/vue';
 import { ionicFetchingDataAsync } from '../utils/ionic-fetching';
-import type { DataResult } from '~razor-common/types/common';
 
 // Mocking Ionic controllers
 vi.mock('@ionic/vue', () => ({

diff --git a/layers/mobile/utils/ionic-fetching.ts b/layers/mobile/utils/ionic-fetching.ts
@@ -1,5 +1,4 @@
 import { loadingController, alertController } from '@ionic/vue';
-import type { DataResult } from '~razor-common/types/common';
 import { fetchingResultAsync } from '~razor-common/utils/typed-fetching';
 
 function _failure(message?: string, code?: string) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -36,4 +36,4 @@ @@
         "@vueuse/nuxt": "catalog:common",
         "vue": "catalog:common"
       }
-    }
+    }