Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Felipe Castanheira] Gerador de Senhas #2

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

[Felipe Castanheira] Gerador de Senhas #2

wants to merge 13 commits into from

Conversation

FelipeCastanheira
Copy link

No description provided.

henriquejensen
henriquejensen reviewed Feb 11, 2022
View reviewed changes
src/pages/Profile.jsx Outdated
userData: PropTypes.shape({
email: PropTypes.string,
}),
passwordData: PropTypes.objectOf(PropTypes.string),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O ideal é definir o tipo com shape. Visto que essa definicao se repete em outros arquivos, voce pode criar um arquivo com essa definicao e importar onde for usar

@henriquejensen
Copy link
Contributor

Para rodar o rojeto eu tive que adicionar as seguintes libs:

    "react-redux": "^7.2.6",
    "react-router-dom": "^5.3.0",
    "redux": "^4.1.2",

acredito que faltou 1 commit final delas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henriquejensen henriquejensen henriquejensen left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@GabiFerraz GabiFerraz

@FelipeCastanheira FelipeCastanheira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FelipeCastanheira @henriquejensen @GabiFerraz