Reimplament vulnerability endpoint logic #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejanb
force-pushed
the
sbom-vuln-purls-db
branch
from
199f502 to
1b4bb54
Compare
carlosthe19916
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
@dejanb Thanks for the quick PR. I tested it and it looks great. I can use that for the UI!!
I intentionally left statuses for now in order not to break current UI. We can change that later on, once UI catches up
Thank, but after testing this PR I realized the amount of changes I will need to do in the UI is minimal. So we can either remove the current statuses field or put the current purl_statuses into that field. Whatever makes more sense for you!
…ieve purls for affected sboms
dejanb
force-pushed
the
sbom-vuln-purls-db
branch
from
1334f93 to
a3670a2
Compare
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to change the API to return list of purl statuses for every sbom that is returned.
The new statuses should be under advisory->sboms->purl_statuses
I intentionally left statuses for now in order not to break current UI. We can change that later on, once UI catches up
@carlosthe19916 Please give it a try and let me know if this is something you can work with
I'll go document and clean code some more next