Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to latest NodeJS LTS version #328

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Jan 29, 2025

NodeJS 22 is LTS

  • Using UBI9/nodejs-22 for Dockerfiles
  • Updated github workflows accordingly
  • Bump Storybook dependencies to support nodejs 22
  • Bump @hey-api dependencies to support nodejs 22; Generated files don't need to be committed but need to be generated for the build.

Fix #327

@gildub gildub requested a review from carlosthe19916 January 29, 2025 21:20
@gildub gildub force-pushed the bump-nodejs branch 12 times, most recently from 17f1c47 to 87fb0cb Compare January 30, 2025 17:16
Copy link
Member

@carlosthe19916 carlosthe19916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test are failing. And it is due to the changes in this PR. See this other test PR I created #330 , the tests are passing but they fail here. https://github.com/trustification/trustify-ui-tests has quite a simple test so there is something wrong with this PR. Please clone that repo and make sure this PR does not break that basic test... on a side note, I am happy that we have the e2e tests even at a basic level, we can capture these kind of things, that hopefully those test will get even better.

On the other hand. If I execute:

npm run start:dev

In a clean environment I get the error:

Cannot find module '@app/client' or its corresponding type declarations

That is caused because we are not including client/src/app/client/ anymore. While I see the reason behind ignoring that folder, seems like it is not actually solving a problem but creating one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support lates nodejs LTS version 22
2 participants