Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove defaultProps from DatePicker and Tooltip #2949

Merged
merged 4 commits into from
Jul 18, 2024
Merged

fix: remove defaultProps from DatePicker and Tooltip #2949

merged 4 commits into from
Jul 18, 2024

Conversation

aligg
Copy link
Contributor

@aligg aligg commented Jun 14, 2024

Summary

  • remove use of defaultProps from DatePicker and Tooltip (DatePicker already sets the default (code) and I added in the position default in Tooltip)
  • This is my first time contributing so guidance appreciated if I missed anything

Related Issues or PRs

#2918

How To Test

I ran through the unit tests locally - can add additional testing if we think we need.

Screenshots (optional)

N/A

@aligg aligg requested a review from a team as a code owner June 14, 2024 23:41
@aligg aligg mentioned this pull request Jun 17, 2024
Open
Steven7926
Steven7926 approved these changes Jun 25, 2024
View reviewed changes
Copy link

@Steven7926 Steven7926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, TY!

brandonlenz
brandonlenz previously approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@brandonlenz brandonlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is good as is, one nit/suggestion I'd like to hear thoughts on before merging

src/components/Tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
@aligg aligg requested a review from brandonlenz July 18, 2024 02:04
@brandonlenz brandonlenz merged commit 88947ca into trussworks:main Jul 18, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonlenz brandonlenz brandonlenz approved these changes

@Steven7926 Steven7926 Steven7926 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aligg @brandonlenz @Steven7926