Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to USWDS 3.8.1 #2848

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

feat: upgrade to USWDS 3.8.1 #2848

wants to merge 42 commits into from

Conversation

werdnanoslen
Copy link
Contributor

@werdnanoslen werdnanoslen commented Mar 22, 2024

Summary

These are the features released by USWDS in 3.8.0 and 3.8.1:

  • Added styles for indeterminate checkboxes and radios
  • Added the ability to customize which headings will be pulled into the in-page navigation link list
    • Also changed class name and selection criteria for bolded heading
  • Added a sticky header variant to the table component
  • Updated sidenav example in documentation per new theme setting
  • Make tooltip content hoverable
  • Make tooltip dismissible with escape key

Related Issues or PRs

Merged with, and closed, #2962

How To Test

Confirm things work the same as release/PR notes in https://github.com/uswds/uswds/releases/tag/v3.8.0 and https://github.com/uswds/uswds/releases/tag/v3.8.1

Screenshots (optional)

Otherwise, headers need to be in a certain DOM context to avoid a11y issues, and this is how USWDS does it
also matches uswds implementation, fixed tests
@werdnanoslen werdnanoslen added the uswds update Update to a new USWDS version label Mar 22, 2024
@jpandersen87
Copy link
Contributor

jpandersen87 commented Mar 22, 2024

There are major differences in how the components are expected to render after updating to 3.8.0 according to the happo check on dependabot: https://happo.io/a/371/p/453/compare/3fa28c8307424f927466a25545b13fe7e21c6a51/4864fc74278db819f28e2d3fc3da0d724b174aad

@werdnanoslen
Copy link
Contributor Author

There are major differences in how the components are expected to render after updating to 3.8.0 according to the happo check on dependabot: https://happo.io/a/371/p/453/compare/3fa28c8307424f927466a25545b13fe7e21c6a51/4864fc74278db819f28e2d3fc3da0d724b174aad

Yep, this PR will integrate those changes. I wouldn't merge that dependabot upgrade until we have these all sorted, which is why I included it in this PR. FYI @crwallace

@werdnanoslen werdnanoslen marked this pull request as ready for review May 13, 2024 17:20
@werdnanoslen werdnanoslen requested review from a team as code owners May 13, 2024 17:20
Base automatically changed from an-storybooka11y-fixes to main June 20, 2024 20:48
@werdnanoslen werdnanoslen changed the title [feat] USWDS 3.8.0 features feat: USWDS 3.8.0 features Jun 20, 2024
@werdnanoslen werdnanoslen changed the title feat: USWDS 3.8.0 features feat: upgrade to USWDS 3.8.1 Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
uswds update Update to a new USWDS version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants