-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to USWDS 3.8.1 #2848
base: main
Are you sure you want to change the base?
Conversation
Otherwise, headers need to be in a certain DOM context to avoid a11y issues, and this is how USWDS does it
also matches uswds implementation, fixed tests
…uswds into an-storybooka11y-fixes
There are major differences in how the components are expected to render after updating to 3.8.0 according to the happo check on dependabot: https://happo.io/a/371/p/453/compare/3fa28c8307424f927466a25545b13fe7e21c6a51/4864fc74278db819f28e2d3fc3da0d724b174aad |
Yep, this PR will integrate those changes. I wouldn't merge that dependabot upgrade until we have these all sorted, which is why I included it in this PR. FYI @crwallace |
… in-page navigation link list
- Make tooltip content hoverable - Make tooltip dismissible with escape key
Summary
These are the features released by USWDS in 3.8.0 and 3.8.1:
Related Issues or PRs
Merged with, and closed, #2962
How To Test
Confirm things work the same as release/PR notes in https://github.com/uswds/uswds/releases/tag/v3.8.0 and https://github.com/uswds/uswds/releases/tag/v3.8.1
Screenshots (optional)