fix!: Label is mandatory for TimePicker component

[m7adeel]

Summary

Resolved mandatory label prop requirement for the time picker component, enhancing compliance with USWDS documentation.

Related Issues or PRs

Closes #2611

How To Test

The developer can try to add a TimePicker component without a label prop which would result in a typescript error with a msg of (Property 'label' is missing)

Screenshots

[m7adeel]

Hello @shkeating, I have worked on this issue can you kindly review it?

[brandonlenz]

@m7adeel please update the tests for TimePicker to include a label, now that label is mandatory on this branch tests are failing as a result

[brandonlenz]

Updated title to fix! as this will be a breaking change, mandating a major version bump on the next release

[AnnaGingle]

Hello. I will do a design review on this.

[AnnaGingle]

Looks good to me! Great work. I do have some feedback on the PR instructions, particularly the how to test section. I humbly suggest adding a sentence or two about how the PR relates to the design of the component. It's a great way to get new design contributors in the door.

[AnnaGingle]

LGTM

[AnnaGingle]

I did notice the time picker component label is using Start Case where it should be using sentence case.
-This Sentence Is Called A Start Case.
-This sentence is called a sentence case.
The USWDS website uses sentence case & it’s better for accessibility.

[brandonlenz]

Noticing the lockfiles got corrupted on this branch. Gonna try to resolve to move this along

[brandonlenz]

Noticing the lockfiles got corrupted on this branch. Gonna try to resolve to move this along

Ah right, I'd have to make a fork of your fork for those updates to display in github.

@m7adeel can you resolve the issues with the lock files? Looks like maybe an npm command was issued?

My recommendation:

1. Delete package-lock.json (we use yarn on this project)
2. Revert any changes to yarn.lock. There should be no diff here as package.json was not changed. This PR includes code changes only

[m7adeel]

@brandonlenz I have fixed the issues

[AnnaGingle]

I did notice the time picker component label is using Start Case where it should be using sentence case.
This Sentence Is Called A Start Case.
This sentence is called a sentence case.
The USWDS website uses sentence case & it’s better for accessibility.

[brandonlenz]

I did notice the time picker component label is using Start Case where it should be using sentence case. This Sentence Is Called A Start Case. This sentence is called a sentence case. The USWDS website uses sentence case & it’s better for accessibility.

@AnnaGingle I'm seeing this PR updated to sentence case. Can you confirm?

[AnnaGingle]

Looks good to me!