Allow 'latest' as wasm-opt version #975
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be good splitting the default version update and the addition of "latest" into different PRs. Updating the default version seems like a quick one. While the other requires more thinking. |
Madoshakalaka
force-pushed
the
allow-latest-as-version
branch
from
b5dc78d to
f1cb4b4
Compare
|
anything lacking? I'm not familiar with the testing code here but I can explore if that's necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some manual testing on my system with and without system-installed wasm-opt; with and without using the
latestkeyword, with specified versions etc. All seem to work fine.also bumped default wasm-opt version toversion_123I think also #904 can be closed since from my testing new wasm_opt versions processe the binary successfully without any workarounds.PS. tried both version_122 and version_123. And 123 is soooo fast. Did a rough test and it's like 30 seconds vs 5 seconds,as advertised
> Given the big speedup in our official release binaries for Linux, thisseems useful to get to users quickly.
I think it's a worthwhile bump.