Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aws-lc-sys dependency #923

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Remove aws-lc-sys dependency #923

merged 4 commits into from
Dec 20, 2024

Conversation

stefnotch
Copy link
Contributor

@stefnotch stefnotch commented Dec 11, 2024

This ensures that cargo build --no-default-features -F update_check,rustls works as intended on Windows once again.
Fix #920

It's possible for users to opt-in into aws-lc-sys by depending on rustls themselves, and enabling the feature.

@ctron
Copy link
Collaborator

ctron commented Dec 12, 2024

I absolutely like the idea of bringing back a sane rustls mode for cargo install.

However, I think it would make sense to default trunk's build to just cargo install. and have openssl used with cargo install --no-default-features -F openssl. And it someone wants aws-lc-sys, then have cargo install --no-default-features -F rustls-awc-lc.

@stefnotch
Copy link
Contributor Author

Glad to hear that you also think so!

I figured I'd put the most critical tweak into this PR, and then open another PR that changes the default to be rustls without aws. As in, this should be ready to merge right away.

@ctron
Copy link
Collaborator

ctron commented Dec 12, 2024

I'd prefer to have a single PR and release this right away. I'd consider this an (un)breaking change :)

@stefnotch
Copy link
Contributor Author

I have changed Trunk's default to use rustls without aws-lc-sys.
With rustls-aws-lc, one can opt ino the aws-lc-sys. And with native-tls one can opt into OpenSSL.

@ctron ctron added this pull request to the merge queue Dec 20, 2024
Merged via the queue into trunk-rs:main with commit d4d92c4 Dec 20, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows install fails with defaults
2 participants