Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added OS-specific overrides for hooks. #874

Closed
wants to merge 1 commit into from
Closed

Added OS-specific overrides for hooks. #874

wants to merge 1 commit into from

Conversation

bicarlsen
Copy link
Contributor

Adds OS-specific overrides for hooks.
Addresses Issue #792.

@ctron
Copy link
Collaborator

ctron commented Sep 13, 2024

Thanks for the PR. I did notice this targets 0.20.x of trunk. However, it should be based on main, for the 0.21.x release.

@bicarlsen
Copy link
Contributor Author

Is it possible to merge this so current users have it, and I can create another PR for 0.21.x?

@ctron
Copy link
Collaborator

ctron commented Sep 13, 2024

Is it possible to merge this so current users have it, and I can create another PR for 0.21.x?

I really don't want to push out new features to 0.20.x, I'd prefer to focus on the next release.

@bicarlsen
Copy link
Contributor Author

Closed in favor of PR #877.

@bicarlsen bicarlsen closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bicarlsen @ctron