Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling CSS minification per file #652

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

abusch
Copy link
Contributor

@abusch abusch commented Dec 20, 2023

See #651

This should allow us to disable CSS minification for problematic files until a better solution is found.

@ctron
Copy link
Collaborator

ctron commented Dec 20, 2023

I think it would be nice to have this, the same way, for other assets (e.g. JS) too.

@abusch abusch force-pushed the disable-css-minify branch 2 times, most recently from 67ec064 to 3282753 Compare December 20, 2023 08:26
@abusch
Copy link
Contributor Author

abusch commented Dec 20, 2023

There's still html minification, but I'm not sure where the attribute would go... The <html> doesn't seem to have any configuration at the moment.

@abusch abusch force-pushed the disable-css-minify branch from 3282753 to 2e18c03 Compare December 20, 2023 08:43
@ctron ctron added this to the 0.18.3 milestone Dec 20, 2023
@ctron
Copy link
Collaborator

ctron commented Dec 20, 2023

There's still html minification, but I'm not sure where the attribute would go... The <html> doesn't seem to have any configuration at the moment.

True, but I think it's good enough :)

@ctron ctron merged commit 4b68c74 into trunk-rs:main Dec 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants