Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch back to rustls #628

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Conversation

ctron
Copy link
Collaborator

@ctron ctron commented Dec 13, 2023

Using native-tls for serve components is tricky/not possible. Having native OS for the client side of things might be nice, but having two TLS stacks in a single application doesn't feel good either.

Removing native-tls drops a number of dependencies, which might be a good thing too.

Using native-tls for serve components is tricky/not possible. Having
native OS for the client side of things might be nice, but having two
TLS stacks in a single application doesn't feel good either.

Removing native-tls drops a number of dependencies, which might be a
good thing too.
@ctron ctron force-pushed the feature/use_rusttls_1 branch from 3c456b9 to 85e0543 Compare December 17, 2023 16:06
@ctron ctron merged commit 8477690 into trunk-rs:main Dec 17, 2023
5 checks passed
@ctron ctron deleted the feature/use_rusttls_1 branch December 17, 2023 16:37
@kekonn
Copy link
Contributor

kekonn commented Dec 19, 2023

Curious if this will break Trunk for me again. Will report back when it's released

@ctron
Copy link
Collaborator Author

ctron commented Dec 19, 2023

rusttls is already being used in the server side things of trunk. It actually removes a bunch of dependencies.

@kekonn
Copy link
Contributor

kekonn commented Dec 19, 2023

rusttls is already being used in the server side things of trunk. It actually removes a bunch of dependencies.

I misunderstood. I thought rustls-native-roots was being swapped out for the non-native version. But this change probably won't affect me.

@ctron
Copy link
Collaborator Author

ctron commented Dec 19, 2023

Nope, it should not affect you at all … I hope 🤞

@kekonn
Copy link
Contributor

kekonn commented Dec 19, 2023

Can confirm it still works! Even without the extra flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants