Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version matching for sass compiled with dart2js #613

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

lelgenio
Copy link
Contributor

sass may report the version differently if it's the nodejs version of dart-sass:

$ sass --version
1.62.1 compiled with dart2js 2.19.6

I would expect the version to be 1.62.1, but currently trunk thinks it's 1.62.1 compiled with dart2js 2.19.6.

Checklist

  • Updated CHANGELOG.md describing pertinent changes.
  • Updated README.md with pertinent info (may not always apply).
  • Updated site content with pertinent info (may not always apply).
  • Squash down commits to one or two logical commits which clearly describe the work you've done. If you don't, then Dodd will 🤓.

Fixes: #541

@ctron ctron added the disposition:merge The tagged item should probably be merged label Dec 12, 2023
@ctron ctron merged commit dcd0416 into trunk-rs:master Dec 12, 2023
4 of 5 checks passed
ctron added a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition:merge The tagged item should probably be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TRUNK_TOOLS_SASS has unexpected format requirements
2 participants