Account for Forked PRs + refactor testing #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pv72895
commented
Feb 12, 2024
| echo "Missing API Token" | ||
| # API Token is required if PR is not from a fork, or | ||
| # RUN ID is required if PR is from a fork | ||
| if [[ (-z ${API_TOKEN-}) && (${IS_FORK} == 'false') ]]; then |
There was a problem hiding this comment.
It looks like the action was still allowing the request through when the API token wasn't provided
gnalh
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR includes necessary updated for getting the merge action to work for forked PRs. When this action runs on
pull_requestevents for forked PRs, the action will not have access to any secrets, most likely including the trunk token necessary for this action to work. To account for this, thesetImpactedTargetsAPI allows for uploading impacted targets using the github workflow run ID of the job that is uploading impacted targets. If the provided ID belongs to an in-progress run from a forked PR, and the SHA within the request matches that SHA of that workflow run ID, then the upload will be allowedThis PR handles the above, making it so that if the workflow is coming from a fork, we properly make the
setImpactedTargetsAPI call using the forked workflow run IDChanges to how this action is used
None
Testing
I added tests verifying the new conditions around not always needing the API token. Additionally, I refactored the tests to make future changes like this easier
Other changes