Fix issue with empty notification ID

trumpee · Jun 2, 2024 · 7873dd1 · 7873dd1
1 parent 0d120bb
commit 7873dd1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Core/Services/NotificationService.cs b/src/Core/Services/NotificationService.cs
@@ -22,6 +22,7 @@ public async Task<ErrorOr<NotificationDto>> CreateNotification(
 
         ct.ThrowIfCancellationRequested();
         await notificationsRepository.InsertOne(notification);
+        dto = dto with { Id = notification.Id.ToString() };
 
         var deliveryRequests = CreateDeliveryRequests(dto).ToList();
 
@@ -31,8 +32,7 @@ public async Task<ErrorOr<NotificationDto>> CreateNotification(
             await notificationsAnalyticsClient
                 .SendNotificationCreated(deliveryRequest.NotificationId, ct);
         }
-
-        dto = dto with { Id = notification.Id.ToString() };
+
         return dto;
     }