-
Notifications
You must be signed in to change notification settings - Fork 418
Add Contentful to website build process #1204
base: main
Are you sure you want to change the base?
Add Contentful to website build process #1204
Conversation
…s://github.com/trufflesuite/trufflesuite.com into dx-team/issues/970-Integration-with-Contentful
Build is failing. Can you fix it and ping me when it's working? |
At first glance this seems to remove the ability for us to create reproducible website builds. There seems to be no way to track changes to content over time I think it is very important for our website content to be transparent and auditable by the community. Is it possible to manage content in Contentful but automatically mirror that content here on GitHub? |
Hi @davidmurdoch, |
@kevinbluer I'm pretty sure I have a fleek account, but when I signed in with the two accounts I know I have and did see the Truffle account under either of them. :-/ Can you take a look to see if I'm added to the team, and if not, add me? |
hey @davidmurdoch, invite on the way 👍 |
I think some changes need to be made to this integration. It must to be impossible for the website "Build Preview" (i.e., the contents of the PR itself) to differ from what gets built once the PR is merged. So the Contentful integration probably needs to push all relevant data to a GitHub PR, so we can properly review the changes here, rather than just trust that whatever the preview says is what the actual content is (we also need to approve any changes via PR first). Also, at first glance it looks like there might be changes and modules added here that aren't used (like And just a heads up: I think all members of trufflesuite will need a Contentful account before this gets merged (@gnidan your thoughts on this would be appreciated), and we'll need to add Contentful to a onboarding process. |
Hi @davidnguyen88 @cuonglt-ync , Can you help @davidmurdoch with the above? |
#1204 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some changes need to be made to this integration. It must to be impossible for the website "Build Preview" (i.e., the contents of the PR itself) to differ from what gets built once the PR is merged. So the Contentful integration probably needs to push all relevant data to a GitHub PR, so we can properly review the changes here, rather than just trust that whatever the preview says is what the actual content is (we also need to approve any changes via PR first).
Also, at first glance it looks like there might be changes and modules added here that aren't used (like github-list, for example?)
And just a heads up: I think all members of trufflesuite will need a Contentful account before this gets merged (@gnidan your thoughts on this would be appreciated), and we'll need to add Contentful to a onboarding process.
https://github.com/ConsenSys/dx-team/issues/970