This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Remove all preserve plugins from truffle bundle #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cds-amal
force-pushed
the
ipfs-burns
branch
3 times, most recently
from
d952e60
to
ddb7afb
Compare
eggplantzzz
reviewed
May 27, 2022
eggplantzzz
approved these changes
May 27, 2022
|
any way to get the @truffle/error thing sorted out first? seems like it's just a dependency missing in one or all of the preserve packages |
|
So, uh, this is a breaking change to Truffle, right...? |
the assumption is that no one is using this feature, and so we can make the pragmatic decision to avoid the rigamarole of a Truffle major release, and just compensate with apologies and good instructions |
|
- remove preserve-to-* plugins - remove preserve-fs plugin - truffle: remove unused deps
- `help preserve` no longer asserts for defaultPlugins.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the preserve plugins from the truffle bundle, which will 1) improve installation time [#5116] and 2) silence a bunch of noisy dependencies during installation. Unfortunately, the
preserve-to-*integration tests are no more; however, there is now an issue on the preserves monorepo for followup work.Users who currently use the preserve feature, will have to
@truffle/error@truffle/preserve-fs@truffle/preserve-to-ipfs@truffle/preserve-to-filecoin"@truffle/preserve-fs"to thepluginsarray intruffle-config.jsWhen this is released, the accompanying
preserve-example-box PRcan be merged.Testing install time
cd packages/truffle; yarn packnpm -g uninstall truffletime npm -g install truffle-v5.5.16.tgz