Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Commit

Permalink
Merge pull request #5374 from trufflesuite/develop
Browse files Browse the repository at this point in the history
chore(release): 2.7.1-beta
  • Loading branch information
jeffsmale90 authored Mar 30, 2023
2 parents 0d643ac + e913d3c commit f3e2636
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 10 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ This will create a signed `.dmg` file in `./out/make`.

#### On Linux:

Bulding on Linux will create a `.AppImage` file, meant to run on many versions of Linux.
Building on Linux will create a `.AppImage` file, meant to run on many versions of Linux.

Linux requires no signing keys, so there's no set up. Simply run the following command:

Expand All @@ -105,11 +105,11 @@ Note from the author: I found managing these assets manually -- especially the a

### Flavored Development

"Extras" aren't stored here in this repository fordue to file size issues, licensing issues, or both.
"Extras" aren't stored here in this repository due to file size issues, licensing issues, or both.

Non-ethereum "flavored" Ganache extras are uploaded to releases here: https://github.com/trufflesuite/ganache-flavors/releases

When "extras" change they should be uploaded to a new release, and a corresonding Ganache release that targets the new ganache-flavors release (see `common/extras/index.js` for what you'dd need to update)
When "extras" change they should be uploaded to a new release, and a corresponding Ganache release that targets the new ganache-flavors release (see `common/extras/index.js` for what you'd need to update)

### VS Code Debugging

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@ganache/ui",
"productName": "Ganache",
"version": "2.7.0",
"version": "2.7.1-beta",
"description": "Personal Blockchain for Ethereum",
"repository": {
"type": "git",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,12 @@ class TruffleIntegrationService extends EventEmitter {
return new Promise((resolve, reject) => {
if (this.child !== null && this.child.connected) {
this.once("decode-event-response", data => {
if (typeof data === "object") {
resolve(data);
if (data && data.error) {
reject(data.error);
} else {
reject(data);
// data may be `undefined`, in which case the raw event will be displayed
// see https://github.com/trufflesuite/ganache-ui/issues/5296 for details
resolve(data);
}
});
this.child.send({
Expand All @@ -185,10 +187,12 @@ class TruffleIntegrationService extends EventEmitter {
return new Promise((resolve, reject) => {
if (this.child !== null && this.child.connected) {
this.once("decode-transaction-response", data => {
if (typeof data === "object") {
resolve(data);
if (data && data.error) {
reject(data.error);
} else {
reject(data);
// data may be `undefined`, in which case the raw event will be displayed
// see https://github.com/trufflesuite/ganache-ui/issues/3805 for details
resolve(data);
}
});

Expand Down

0 comments on commit f3e2636

Please sign in to comment.