Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-134194 / 25.10 / More strict null fixes #11556

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Feb 13, 2025

Testing:

Code review and shallow testing.

# Conflicts:
#	src/app/pages/instances/components/instance-wizard/instance-wizard.component.ts
@undsoft undsoft requested a review from a team as a code owner February 13, 2025 14:50
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team February 13, 2025 14:50
@bugclerk bugclerk changed the title NAS-134194: More strict null fixes NAS-134194 / 25.10 / More strict null fixes Feb 13, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 72.80702% with 31 lines in your changes missing coverage. Please review.

Project coverage is 83.30%. Comparing base (2a701fc) to head (63f9ec1).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...omponents/ix-code-editor/ix-code-editor.harness.ts 9.09% 10 Missing ⚠️
...pages/system/enclosure/services/enclosure.store.ts 33.33% 4 Missing ⚠️
...dules/alerts/components/alert/alert.page-object.ts 75.00% 2 Missing ⚠️
...omponents/alerts-panel/alerts-panel.page-object.ts 75.00% 2 Missing ⚠️
...s/forms/toolbar-slider/toolbar-slider.component.ts 0.00% 2 Missing ⚠️
src/app/pages/apps/resolvers/app-name.resolver.ts 0.00% 2 Missing ⚠️
...g/mock-enclosure/mock-enclosure-generator.utils.ts 0.00% 1 Missing ⚠️
src/app/directives/ui-search.directive.ts 66.66% 1 Missing ⚠️
.../app/modules/feedback/services/feedback.service.ts 66.66% 1 Missing ⚠️
...ms/components/ix-combobox/ix-combobox.component.ts 0.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11556      +/-   ##
==========================================
+ Coverage   83.28%   83.30%   +0.02%     
==========================================
  Files        1654     1654              
  Lines       59100    59135      +35     
  Branches     6354     6381      +27     
==========================================
+ Hits        49219    49261      +42     
+ Misses       9881     9874       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks & works fine 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants