-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-133897 / 25.10 / Add disk reporting temps #11542
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11542 +/- ##
==========================================
+ Coverage 83.25% 83.28% +0.02%
==========================================
Files 1653 1654 +1
Lines 59020 59103 +83
Branches 6345 6355 +10
==========================================
+ Hits 49139 49222 +83
Misses 9881 9881 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disk reports, including Temperatures, are shown on m40, but there is a Cannot read properties of undefined (reading 'split')
error when trying to access Disk reports on a CI machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reports appear to be functioning correctly now.
This PR has been merged and conversations have been locked. |
Testing:
At the Reporting > Disks screen,
Expected result: the disk temperature data displayed correctly