Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133897 / 25.10 / Add disk reporting temps #11542

Merged
merged 2 commits into from
Feb 15, 2025
Merged

NAS-133897 / 25.10 / Add disk reporting temps #11542

merged 2 commits into from
Feb 15, 2025

Conversation

bvasilenko
Copy link
Contributor

Testing:

At the Reporting > Disks screen,

Expected result: the disk temperature data displayed correctly

@bvasilenko bvasilenko requested a review from a team as a code owner February 12, 2025 06:05
@bvasilenko bvasilenko requested review from RehanY147 and removed request for a team February 12, 2025 06:05
@bugclerk bugclerk changed the title NAS-133897: Add disk reporting temps NAS-133897 / 25.10 / Add disk reporting temps Feb 12, 2025
@bugclerk
Copy link
Contributor

@bvasilenko bvasilenko added the backport-25.04-RC.1 Fangtooth RC1 label Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (d388b5e) to head (164ab28).
Report is 14 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11542      +/-   ##
==========================================
+ Coverage   83.25%   83.28%   +0.02%     
==========================================
  Files        1653     1654       +1     
  Lines       59020    59103      +83     
  Branches     6345     6355      +10     
==========================================
+ Hits        49139    49222      +83     
  Misses       9881     9881              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disk reports, including Temperatures, are shown on m40, but there is a Cannot read properties of undefined (reading 'split') error when trying to access Disk reports on a CI machine.

@bvasilenko bvasilenko requested a review from undsoft February 14, 2025 12:54
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reports appear to be functioning correctly now.

@bvasilenko bvasilenko merged commit 08bc7de into master Feb 15, 2025
9 checks passed
@bvasilenko bvasilenko deleted the NAS-133897 branch February 15, 2025 06:40
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants