Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133545 / 25.04 / Fix loading indicator #11333

Merged
merged 4 commits into from
Jan 15, 2025
Merged

NAS-133545 / 25.04 / Fix loading indicator #11333

merged 4 commits into from
Jan 15, 2025

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jan 14, 2025

Changes
Fixes spinner that broke because of strict null fixes.
Add some unrelated defensive coding checks in terminal and fixes tooltip in API keys.

Testing:

Check anything that shows a spinner.

@undsoft undsoft requested a review from a team as a code owner January 14, 2025 00:21
@undsoft undsoft requested review from RehanY147 and removed request for a team January 14, 2025 00:21
@bugclerk bugclerk changed the title NAS-133545: Fix loading indicator NAS-133545 / 25.04 / Fix loading indicator Jan 14, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.74%. Comparing base (248fd2c) to head (23fe20f).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...terminal/components/terminal/terminal.component.ts 0.00% 7 Missing ⚠️
src/app/modules/loader/app-loader.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11333      +/-   ##
==========================================
- Coverage   82.75%   82.74%   -0.02%     
==========================================
  Files        1654     1654              
  Lines       59132    59137       +5     
  Branches     6217     6218       +1     
==========================================
- Hits        48934    48932       -2     
- Misses      10198    10205       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit 8b1d69b into master Jan 15, 2025
10 of 11 checks passed
@undsoft undsoft deleted the NAS-133545 branch January 15, 2025 00:48
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants