Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133467 / 24.10.2 / GUI: Extending VDEV progress is blocking #11327

Closed
wants to merge 210 commits into from

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

Code review may be enough.

bugclerk and others added 30 commits August 12, 2024 17:21
)

* NAS-130545: Fixed container shell access

(cherry picked from commit 2c8306e)

* NAS-130545: Remove details that aren't required

(cherry picked from commit 6435316)

* NAS-130545: Fixed tests

(cherry picked from commit c42310c)

* NAS-130545: Fixed container shell access

(cherry picked from commit edf54dd)

---------

Co-authored-by: RehanY147 <[email protected]>
Co-authored-by: Evgeny Stepanovych <[email protected]>
(cherry picked from commit 9140658)

Co-authored-by: RehanY147 <[email protected]>
…by AlexKarpov98) (#10448)

* NAS-130365: Improve Add Alert Service > Level Tooltip

(cherry picked from commit 91822ca)

* NAS-130365: Improve Add Alert Service > Level Tooltip

(cherry picked from commit 10cf773)

* NAS-130365: Improve Add Alert Service > Level Tooltip

(cherry picked from commit 084e5c3)

---------

Co-authored-by: Alex Karpov <[email protected]>
…tails page (by AlexKarpov98) (#10449)

* NAS-130516: Application Info Card | Add link the app details page

(cherry picked from commit 06bed89)

* NAS-130516: Application Info Card | Add link the app details page

(cherry picked from commit 0cdbd1a)

* NAS-130516: Application Info Card | Add link the app details page

(cherry picked from commit f450133)

* NAS-130516: Application Info Card | Add link the app details page

(cherry picked from commit d58b0dd)

---------

Co-authored-by: Alex Karpov <[email protected]>
(cherry picked from commit 92140fc)

Co-authored-by: Denys Butenko <[email protected]>
…10457)

* NAS-130386: Theme is too persistent

(cherry picked from commit 9dd7bdc)

* NAS-130386: Theme is too persistent

(cherry picked from commit 270f986)

---------

Co-authored-by: Alex Karpov <[email protected]>
(cherry picked from commit 0ba0fba)

Co-authored-by: Alex Karpov <[email protected]>
…by denysbutenko) (#10473)

* NAS-130552: Pick first network interface when no settings

(cherry picked from commit e457cdb)

* NAS-130566: Update data-test tag for view all buttons

(cherry picked from commit 84d3043)

* NAS-130566: Make ixTestOverride required for show-more component

(cherry picked from commit 5fb183e)

* NAS-130566: Update tests

(cherry picked from commit c63d794)

---------

Co-authored-by: Denys Butenko <[email protected]>
…ity picker (by AlexKarpov98) (#10458)

* Empty commit to create PR on github.

You should reset it

* NAS-129938: NFS Share Edit pane: missing help for Security picker (#10445)

(cherry picked from commit 8490b1b)

---------

Co-authored-by: Alex Karpov <[email protected]>
…AlexKarpov98) (#10480)

* NAS-130596: Reword application use warning message

(cherry picked from commit 4513e06)

* NAS-130596: PR update

(cherry picked from commit d0914d7)

---------

Co-authored-by: Alex Karpov <[email protected]>
(cherry picked from commit 8cefb57)

Co-authored-by: Alex Karpov <[email protected]>
* NAS-130604: CPU model widget

(cherry picked from commit b8b6b4c)

* NAS-130604: PR update

(cherry picked from commit 91646e0)

* NAS-130604: PR update

(cherry picked from commit 48c5549)

---------

Co-authored-by: Alex Karpov <[email protected]>
…rting graphs (by AlexKarpov98) (#10498)

* NAS-130254: Setting UK/GB date results in error in Reporting graphs

(cherry picked from commit 6fd777c)

* NAS-130254: PR Update

(cherry picked from commit 4028f2a)

---------

Co-authored-by: Alex Karpov <[email protected]>
…dered properly (by undsoft) (#10501)

* Empty commit to create PR on github.

You should reset it

* NAS-130666: Custom cron schedule is too small to be rendered properly

---------

Co-authored-by: Evgeny Stepanovych <[email protected]>
…ups (by undsoft) (#10502)

* Empty commit to create PR on github.

You should reset it

* NAS-130672: Rename Local Users/Groups to just Users/Groups

---------

Co-authored-by: Evgeny Stepanovych <[email protected]>
#10511)

* NAS-130138: Fix manual dataset unlocking

(cherry picked from commit cb3f762)

* NAS-130138: Restore key choice from file

(cherry picked from commit 34af41d)

---------

Co-authored-by: Boris Vasilenko <[email protected]>
* NAS-130636: Create custom observable to lazily load image

(cherry picked from commit 9bef0b2)

* NAS-130636: Fix tests

(cherry picked from commit 82c76a8)

---------

Co-authored-by: RehanY147 <[email protected]>
…exKarpov98) (#10529)

* Empty commit to create PR on github.

You should reset it

* NAS-129146 / 25.04 / Slow scroll behaviour on Apps screen (#10519)

* NAS-129146: Slow scroll behavior on Apps screen

* NAS-129146: PR Update

* NAS-129146: PR Update

(cherry picked from commit 0008a16)

---------

Co-authored-by: Alex Karpov <[email protected]>
…ov98) (#10526)

* Empty commit to create PR on github.

You should reset it

* NAS-130605 / 25.04 / Various dashboard improvements (#10500)

* NAS-130605: Various dashboard improvements

* NAS-130605: Various dashboard improvements

* NAS-130605: PR Update

* NAS-130605: PR Update

* NAS-130605: PR Update

(cherry picked from commit aebb4ae)

---------

Co-authored-by: Alex Karpov <[email protected]>
…d Key (by AlexKarpov98) (#10525)

* Empty commit to create PR on github.

You should reset it

* NAS-130715 / 25.04 / Better error handling for Download Encrypted Key (#10513)

* NAS-130715: Better error handling for Download Encrypted Key

* NAS-130715: Better error handling for Download Encrypted Key

* NAS-130715: Skip disabled buttons for changes

* NAS-130715: PR update

* Revert "NAS-130715: Skip disabled buttons for changes"

This reverts commit e2083db.

---------

Co-authored-by: Denys Butenko <[email protected]>
(cherry picked from commit e287cea)

---------

Co-authored-by: Alex Karpov <[email protected]>
…as incorrect (by AlexKarpov98) (#10524)

* Empty commit to create PR on github.

You should reset it

* NAS-130656: Portal group IDs on iSCSI target are shown as incorrect (#10512)

(cherry picked from commit 45c1c8e)

---------

Co-authored-by: Alex Karpov <[email protected]>
…y AlexKarpov98) (#10531)

* Empty commit to create PR on github.

You should reset it

* NAS-130607 / 25.04 / Mobile adjustments for dashboard widgets (#10507)

(cherry picked from commit b0d75a1)

---------

Co-authored-by: Alex Karpov <[email protected]>
bugclerk and others added 17 commits December 9, 2024 18:22
(cherry picked from commit 7a88e4a)

Co-authored-by: Boris Vasilenko <[email protected]>
…AlexKarpov98) (#11168)

* Empty commit to create PR on github.

You should reset it

* NAS-132920: PR Update

---------

Co-authored-by: Alex Karpov <[email protected]>
…Cloudsync Tasks (by AlexKarpov98) (#11175)

* Empty commit to create PR on github.

You should reset it

* NAS-132932: PR update

---------

Co-authored-by: Alex Karpov <[email protected]>
… apps (by AlexKarpov98) (#11198)

* Empty commit to create PR on github.

You should reset it

* NAS-133032: PR Update

---------

Co-authored-by: Alex Karpov <[email protected]>
…re visible (by AlexKarpov98) (#11203)

* Empty commit to create PR on github.

You should reset it

* NAS-131851: PR update

* NAS-131851: PR update

---------

Co-authored-by: Alex Karpov <[email protected]>
Co-authored-by: Alex Karpov <[email protected]>
…on but is on edit (by AlexKarpov98) (#11202)

* Empty commit to create PR on github.

You should reset it

* NAS-132967: PR update

---------

Co-authored-by: Alex Karpov <[email protected]>
…by AlexKarpov98) (#11243)

* Empty commit to create PR on github.

You should reset it

* NAS-133127: PR update

---------

Co-authored-by: Alex Karpov <[email protected]>
…#11238)

* Empty commit to create PR on github.

You should reset it

* NAS-133139: PR update

---------

Co-authored-by: Alex Karpov <[email protected]>
…ate after a disconnect/destroy data until screen refresh (by AlexKarpov98) (#11210)

* Empty commit to create PR on github.

You should reset it

* NAS-131994: PR update

---------

Co-authored-by: Alex Karpov <[email protected]>
@AlexKarpov98 AlexKarpov98 self-assigned this Jan 13, 2025
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner January 13, 2025 12:00
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team January 13, 2025 12:00
@bugclerk bugclerk changed the title NAS-133467: GUI: Extending VDEV progress is blocking NAS-133467 / 24.10.2 / GUI: Extending VDEV progress is blocking Jan 13, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 69.98536% with 205 lines in your changes missing coverage. Please review.

Project coverage is 80.00%. Comparing base (b9a1da5) to head (8ced368).
Report is 628 commits behind head on master.

Files with missing lines Patch % Lines
...p/pages/apps/store/installed-apps-store.service.ts 30.00% 42 Missing ⚠️
...-apps/container-shell/container-shell.component.ts 0.00% 32 Missing ⚠️
...ponents/installed-apps/installed-apps.component.ts 43.75% 27 Missing ⚠️
...l-details-dialog/shell-details-dialog.component.ts 26.66% 22 Missing ⚠️
src/app/app.component.ts 0.00% 14 Missing ⚠️
...docker-images-list/docker-images-list.component.ts 56.52% 10 Missing ⚠️
src/app/pages/apps/store/docker.store.ts 50.00% 10 Missing ⚠️
.../components/oauth-button/oauth-button.component.ts 38.46% 8 Missing ⚠️
...-dataset-dialog/create-dataset-dialog.component.ts 54.54% 5 Missing ⚠️
...onents/catalog-settings/apps-settings.component.ts 90.38% 5 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11327      +/-   ##
==========================================
+ Coverage   77.01%   80.00%   +2.99%     
==========================================
  Files        1621     1574      -47     
  Lines       55034    51512    -3522     
  Branches     6466     5944     -522     
==========================================
- Hits        42384    41213    -1171     
+ Misses      12650    10299    -2351     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft
Copy link
Collaborator

undsoft commented Jan 13, 2025

24.10.2 is already in code freeze. Please retarget for master only.

@AlexKarpov98 AlexKarpov98 changed the base branch from stable/electriceel to master January 13, 2025 17:13
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner January 13, 2025 17:13
@AlexKarpov98
Copy link
Contributor Author

will open for master only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants