Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132241 / 25.04 / Use latest version in app bulk upgrade dialog #10970

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Nov 4, 2024

Changes:

Before we just showed "Latest version" because we had to make separate requests to get actual version.
Now there is a field in response we can use.

Testing:

You may need to replace implementation of getLacksNvidiaDrivers() with of(false) in DockerStore due to an unrelated issue.

You can add test train and install 1.0.5 version of nginx to be able to update it.

@undsoft undsoft requested a review from a team as a code owner November 4, 2024 17:13
@undsoft undsoft requested review from RehanY147 and removed request for a team November 4, 2024 17:13
@bugclerk bugclerk changed the title NAS-132241: Use latest version in app bulk upgrade dialog NAS-132241 / 25.04 / Use latest version in app bulk upgrade dialog Nov 4, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Nov 4, 2024

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (bb23d40) to head (2fa7055).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10970   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files        1609     1609           
  Lines       56686    56686           
  Branches     5867     5867           
=======================================
  Hits        46452    46452           
  Misses      10234    10234           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	src/assets/i18n/es-ar.json
#	src/assets/i18n/zh-hans.json
@undsoft undsoft enabled auto-merge (squash) November 5, 2024 12:33
@undsoft undsoft merged commit ea32264 into master Nov 5, 2024
13 checks passed
@undsoft undsoft deleted the NAS-132241 branch November 5, 2024 13:01
@bugclerk
Copy link
Contributor

bugclerk commented Nov 5, 2024

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-132241 is targeted to the following versions which have not received their corresponding PRs: 24.10.1

@bugclerk
Copy link
Contributor

bugclerk commented Nov 5, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants