Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131913 / 24.10.1 / Fix the sequence of state updates #10959

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

RehanY147
Copy link
Contributor

Changes:

We were subscribing to only docker store loading boolean. Should also be listening to docker store state update observable to know when to update installed apps store again.

Testing:

Testing system and method described in the ticket

@RehanY147 RehanY147 requested a review from a team as a code owner November 1, 2024 10:50
@RehanY147 RehanY147 requested review from AlexKarpov98 and removed request for a team November 1, 2024 10:50
@bugclerk
Copy link
Contributor

bugclerk commented Nov 1, 2024

@bugclerk bugclerk changed the title NAS-131913: Fix the sequence of state updates NAS-131913 / 24.10.1 / Fix the sequence of state updates Nov 1, 2024
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

Screen.Recording.2024-11-01.at.12.52.07.mov

@RehanY147 RehanY147 merged commit 558090c into stable/electriceel Nov 1, 2024
7 checks passed
@RehanY147 RehanY147 deleted the NAS-131913-electriceel branch November 1, 2024 10:56
@bugclerk
Copy link
Contributor

bugclerk commented Nov 1, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants