Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129168 / 24.10.1 / Pool name appears modified on Manage Devices page. "AppsPool" shows as "Appspool" (by AlexKarpov98) #10859

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

bugclerk
Copy link
Contributor

Code review is enough.

Original PR: #10822
Jira URL: https://ixsystems.atlassian.net/browse/NAS-129168

…ool" shows as "Appspool"

(cherry picked from commit 4954c19)
@bugclerk bugclerk requested a review from a team as a code owner October 13, 2024 21:10
@bugclerk bugclerk requested review from RehanY147 and removed request for a team October 13, 2024 21:10
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@8e83301). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...es/devices/components/devices/devices.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #10859   +/-   ##
=====================================================
  Coverage                      ?   79.96%           
=====================================================
  Files                         ?     1570           
  Lines                         ?    51382           
  Branches                      ?     5935           
=====================================================
  Hits                          ?    41087           
  Misses                        ?    10295           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit 4f5d2a6 into stable/electriceel Oct 14, 2024
6 of 7 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-129168-24.10.1 branch October 14, 2024 08:41
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants