NAS-128601 / 25.04 / Use undefined instead of EMPTY

[RehanY147]

Changes:

Minor code improvement

Testing:

Code review is enough

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128601

[undsoft]

This is already in 24.10.0.

[undsoft]

Also from the list of changes that needs to be brought from 24.10.1 – there is a check for gpu length that prevents user from removing all gpus from the vm.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (da35a60) to head (ae59683).
Report is 22 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10851      +/-   ##
==========================================
+ Coverage   81.56%   81.92%   +0.35%     
==========================================
  Files        1585     1594       +9     
  Lines       54136    55589    +1453     
  Branches     5814     5816       +2     
==========================================
+ Hits        44158    45539    +1381     
- Misses       9978    10050      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[undsoft]

For fix in .0, I've simply removed the if condition altogether. If this fix is not correct, then it needs to be fixed in .0 as well.
I do think that we could remove the if condition though.

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.