Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logs header in light theme in Container Logs #10850

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

p0358
Copy link
Contributor

@p0358 p0358 commented Oct 11, 2024

Changes:
The text here is unreadable in the white theme:
obraz

It was due to color: #fff being on parent .logs-wrapper instead of actual child .logs element where it's needed to counteract the black background of terminal window.

Testing:
Use light theme and ensure text after header is readable and not white. The logs output should still be white on black.

Downstream

nothing?

Please backport this to the upcoming 24.10.0 too.

@p0358 p0358 requested a review from a team as a code owner October 11, 2024 15:29
@p0358 p0358 requested review from bvasilenko and removed request for a team October 11, 2024 15:29
Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

image

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.56%. Comparing base (17fb4d7) to head (2fa023b).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10850   +/-   ##
=======================================
  Coverage   81.56%   81.56%           
=======================================
  Files        1586     1586           
  Lines       54129    54129           
  Branches     5803     5803           
=======================================
  Hits        44153    44153           
  Misses       9976     9976           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit 930a5f1 into truenas:master Oct 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants