Fix logs header in light theme in Container Logs #10850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The text here is unreadable in the white theme:
It was due to
color: #fff
being on parent.logs-wrapper
instead of actual child.logs
element where it's needed to counteract the black background of terminal window.Testing:
Use light theme and ensure text after header is readable and not white. The logs output should still be white on black.
Downstream
nothing?
Please backport this to the upcoming 24.10.0 too.