Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131565 / 25.04 / Use circle icons for start and stop actions #10827

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

denysbutenko
Copy link
Member

Changes:

Update icons and added text for actions column

Testing:

Check installed apps or other affected places.

Downstream

Affects Reasoning
Documentation Icons has changed

@denysbutenko denysbutenko marked this pull request as ready for review October 9, 2024 04:54
@denysbutenko denysbutenko requested a review from a team as a code owner October 9, 2024 04:54
@denysbutenko denysbutenko requested review from undsoft and removed request for a team October 9, 2024 04:54
@bugclerk bugclerk changed the title NAS-131565: Use circle icons for start and stop actions NAS-131565 / 25.04 / Use circle icons for start and stop actions Oct 9, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Oct 9, 2024

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.33%. Comparing base (8f40cb9) to head (4ffd974).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10827   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files        1577     1577           
  Lines       53045    53044    -1     
  Branches     5795     5794    -1     
=======================================
+ Hits        43142    43144    +2     
+ Misses       9903     9900    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼

@denysbutenko denysbutenko merged commit b034c97 into master Oct 9, 2024
9 checks passed
@denysbutenko denysbutenko deleted the NAS-131565 branch October 9, 2024 09:33
@bugclerk
Copy link
Contributor

bugclerk commented Oct 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants