Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131461 / 24.10.0 / Listen for apps stats only when have installed apps (by denysbutenko) #10825

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Oct 8, 2024

Automatic cherry-pick failed. Please resolve conflicts by running:

git cherry-pick -x 0090fc9c7d4589f613fa8bdd829995aab44376be
git cherry-pick -x 2a833a69df7113527a9768f70697c12ee17bd1da

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x e64b7afea254d2d8ba01e8be732609591ee0c86b

Changes:

Listen for apps stats only when have installed apps

Testing:

Check websocket messages

Original PR: #10791
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131461

@denysbutenko denysbutenko marked this pull request as ready for review October 8, 2024 19:29
@denysbutenko denysbutenko requested a review from a team as a code owner October 8, 2024 19:29
@denysbutenko denysbutenko requested review from AlexKarpov98 and removed request for a team October 8, 2024 19:29
Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported

@denysbutenko denysbutenko merged commit 6b89543 into stable/electriceel Oct 8, 2024
1 of 2 checks passed
@denysbutenko denysbutenko deleted the NAS-131461-24.10.0 branch October 8, 2024 19:34
@bugclerk
Copy link
Contributor Author

bugclerk commented Oct 8, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants