Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131636 / 24.10.0 / Loader is not closed when there are errors when stopping … (by undsoft) #10819

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Oct 7, 2024

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 0d16e59303e50bd74216f5655c0b4817a901c729

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x f838c9c53f95873291f2d32a3049a1ccd9514b94

When I created an app with the following yaml:

version: '3.8'
services:
  nginx:
    image: nginx:1-alpine
    ports:
      - 8089:80
    volumes:
      - ./html5up-stellar/:/usr/share/nginx/html

I couldn't afterwards stop it and loader won't disappear.
If this yaml doens't work for you, you can just add throws manually.

Known issue: starting an app may flash Crashed status. This will be fixed by middleware.

Original PR: #10816
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131636

@undsoft undsoft marked this pull request as ready for review October 7, 2024 14:38
@undsoft undsoft requested a review from a team as a code owner October 7, 2024 14:38
@undsoft undsoft requested review from denysbutenko and removed request for a team October 7, 2024 14:38
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@3cb3e82). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ponents/installed-apps/installed-apps.component.ts 33.33% 4 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #10819   +/-   ##
=====================================================
  Coverage                      ?   79.94%           
=====================================================
  Files                         ?     1570           
  Lines                         ?    51331           
  Branches                      ?     5925           
=====================================================
  Hits                          ?    41036           
  Misses                        ?    10295           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit 2745be5 into stable/electriceel Oct 7, 2024
8 of 9 checks passed
@undsoft undsoft deleted the NAS-131636-24.10.0 branch October 7, 2024 16:20
@bugclerk
Copy link
Contributor Author

bugclerk commented Oct 7, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants