NAS-131266 / 25.04 / Cancel button takes back to apps page #10802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10802 +/- ##
==========================================
+ Coverage 80.91% 81.55% +0.63%
==========================================
Files 1571 1579 +8
Lines 52114 54023 +1909
Branches 5812 5794 -18
==========================================
+ Hits 42167 44056 +1889
- Misses 9947 9967 +20 ☔ View full report in Codecov by Sentry. |
denysbutenko
requested changes
Oct 7, 2024
| timestamp: '[12:34]', | ||
| data: 'Some logs.', | ||
| describe('When dialog is set a value', () => { | ||
| const createComponent = createComponentFactory({ |
There was a problem hiding this comment.
Let's reuse test definition and extract it into setupTest method that accepts params that needs to be changed
denysbutenko
approved these changes
Oct 10, 2024
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
When view button for container logs for an app is clicked, user is taken to show container logs. The cancel button previously didn't take them back to the apps page. Now it does.
Testing:
See ticket description for testing.