Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130834 / 25.04 / App version vs Version is confusing #10793

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

I talked with @stavros-k about this and we agreed to have App Version and Version in some places together and in some places - only Version.

So, we should mainly show the version (which is our packaged app version).
The app_version should show as additional information in:

  • the application info card
  • the upgrade dialog
  • the main app page (where you can see the "install button"

@AlexKarpov98 AlexKarpov98 self-assigned this Oct 3, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner October 3, 2024 08:02
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and stavros-k and removed request for a team October 3, 2024 08:02
@bugclerk bugclerk changed the title NAS-130834: App version vs Version is confusing NAS-130834 / 25.04 / App version vs Version is confusing Oct 3, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Oct 3, 2024

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (303e5cc) to head (1b60ddd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10793   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files        1571     1571           
  Lines       52114    52114           
  Branches     5812     5812           
=======================================
  Hits        42167    42167           
  Misses       9947     9947           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit 80217d7 into master Oct 4, 2024
7 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-130834 branch October 4, 2024 11:47
@bugclerk
Copy link
Contributor

bugclerk commented Oct 4, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants