Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-126907 / 24.10.0 / ix-explorer accessibility improvements (by AlexKarpov98) #10792

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Oct 3, 2024

Testing: see ticket,

Result:
Hitting Space - toggles item (prevents scrolling down)
Hitting Enter - selects item

Screen.Recording.2024-10-02.at.14.21.51.mov

Original PR: #10787
Jira URL: https://ixsystems.atlassian.net/browse/NAS-126907

@bugclerk bugclerk requested a review from a team as a code owner October 3, 2024 07:58
@bugclerk bugclerk requested review from RehanY147 and removed request for a team October 3, 2024 07:58
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@AlexKarpov98 AlexKarpov98 merged commit d50714e into stable/electriceel Oct 3, 2024
5 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-126907-24.10.0 branch October 3, 2024 08:06
@bugclerk
Copy link
Contributor Author

bugclerk commented Oct 3, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants