-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-131461 / 25.04 / Listen for apps stats only when have installed apps #10791
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10791 +/- ##
==========================================
- Coverage 80.91% 80.90% -0.01%
==========================================
Files 1571 1572 +1
Lines 52114 52169 +55
Branches 5812 5807 -5
==========================================
+ Hits 42167 42208 +41
- Misses 9947 9961 +14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.installedApps$
will emit every time there is a change to installed apps, leading to more and more subscriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine, but probably can be optimized further. For example, we won't unsubscribe here when last app is removed, but that's not a big deal.
Unable to perform the following backports: backport-24.10. |
JIRA ticket https://ixsystems.atlassian.net/browse/NAS-131461 is targeted to the following versions which have not received their corresponding PRs: 24.10.0 |
This PR has been merged and conversations have been locked. |
backport |
Unable to perform the following backports: backport-24.10. |
backport |
Changes:
Listen for apps stats only when have installed apps
Testing:
Check websocket messages