Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130954 / 25.04 / Icon sprite #10788

Merged
merged 7 commits into from
Oct 3, 2024
Merged

NAS-130954 / 25.04 / Icon sprite #10788

merged 7 commits into from
Oct 3, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Oct 2, 2024

Changes:

All project icons are now automatically extracted from source code and included in the svg sprite.
Pros:

  • 80KiB
  • to add a custom icon, you just need to put it in custom folder.

Cons:

  • Icons used programmatically need to be marked with iconMarker function.
  • If new icon is used, you either need to restart build or run yarn icons.

Testing:

Test pages for regressions in icons.

# Conflicts:
#	src/app/modules/entity/entity-job/entity-job.component.html
#	src/app/pages/api-keys/api-keys.component.ts
#	src/app/pages/directory-service/components/idmap-list/idmap-list.component.ts
#	src/app/pages/directory-service/components/kerberos-keytabs/kerberos-keytabs-list/kerberos-keytabs-list.component.ts
#	src/app/pages/directory-service/components/kerberos-realms/kerberos-realms-list.component.ts
#	src/app/pages/directory-service/directory-services.component.ts
#	src/app/pages/network/components/interfaces-card/interfaces-card.component.ts
#	src/app/pages/network/network.routing.ts
#	src/app/pages/services/services.component.ts
@undsoft undsoft requested a review from a team as a code owner October 2, 2024 13:56
@undsoft undsoft requested review from denysbutenko and removed request for a team October 2, 2024 13:56
@bugclerk
Copy link
Contributor

bugclerk commented Oct 2, 2024

@bugclerk bugclerk changed the title NAS-130954: Icon sprite NAS-130954 / 25.04 / Icon sprite Oct 2, 2024
Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font packages are still in use?

Nice work

@undsoft
Copy link
Collaborator Author

undsoft commented Oct 3, 2024

Yeah, packages can be removed.

@undsoft undsoft enabled auto-merge (squash) October 3, 2024 08:50
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 79.51807% with 34 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (303e5cc) to head (561e5c6).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...storage/widget-storage/widget-storage.component.ts 50.00% 7 Missing ⚠️
.../app/modules/ix-icon/icon-error-handler.service.ts 50.00% 4 Missing ⚠️
...modules/alerts/components/alert/alert.component.ts 57.14% 3 Missing ⚠️
src/app/modules/empty/empty.component.ts 62.50% 3 Missing ⚠️
...modules/layout/topbar/ix-logo/ix-logo.component.ts 40.00% 3 Missing ⚠️
...rc/app/modules/ix-icon/ix-icon-registry.service.ts 0.00% 2 Missing ⚠️
.../components/ix-empty-row/ix-empty-row.component.ts 75.00% 2 Missing ⚠️
...ules/layout/admin-layout/admin-layout.component.ts 0.00% 2 Missing ⚠️
...ystem/alert-settings2/alert-settings2.component.ts 0.00% 2 Missing ⚠️
src/app/modules/ix-icon/ix-icon.component.ts 87.50% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10788   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files        1571     1572    +1     
  Lines       52114    52161   +47     
  Branches     5812     5807    -5     
=======================================
+ Hits        42167    42206   +39     
- Misses       9947     9955    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit c927481 into master Oct 3, 2024
6 of 7 checks passed
@undsoft undsoft deleted the NAS-130954 branch October 3, 2024 09:33
@bugclerk
Copy link
Contributor

bugclerk commented Oct 3, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants