NAS-131308 / 25.04 / First time accessing a Minio deployment the webui button launches portal is 0.0.0.0:30001 #10769
Conversation
…launches portal is 0.0.0.0:30001
…launches portal is 0.0.0.0:30001
AlexKarpov98
requested review from
bvasilenko
and removed request for
a team
bugclerk
changed the title
| const { | ||
| port, pathname, search, hash, | ||
| } = portalUrl; | ||
| return `${this.window.location.protocol}//${this.window.location.hostname}:${port}${pathname}${search}${hash}`; |
There was a problem hiding this comment.
| const { | |
| port, pathname, search, hash, | |
| } = portalUrl; | |
| return `${this.window.location.protocol}//${this.window.location.hostname}:${port}${pathname}${search}${hash}`; | |
| portalUrl.hostname = this.window.location.hostname; |
Would this work?
There was a problem hiding this comment.
@stavros-k - yeah, it will work, thanks (I'll update the code)
There was a problem hiding this comment.
@stavros-k - is that OK to update Workloads card as well? (to not see 0.0.0.0 there as well?)
There was a problem hiding this comment.
Great question!
The 0.0.0.0 in workload cards shows the interface each port is listening on!
And 0.0.0.0 is valid, it means "All interfaces". So we should leave it as is there and only update the portal button!
There was a problem hiding this comment.
The code is updated now (removed updated logic from Workloads card)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10769 +/- ##
=======================================
Coverage 80.63% 80.63%
=======================================
Files 1570 1570
Lines 51514 51519 +5
Branches 5809 5810 +1
=======================================
+ Hits 41538 41543 +5
Misses 9976 9976
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This PR has been merged and conversations have been locked. |
Testing: see ticket.
I updated it for
App Infocard andWorkloadscard (I see there is as well 0.0.0.0 host ip)Result (instead of 0.0.0.0 we have localhost locally):
Screen.Recording.2024-09-30.at.15.28.03.mov