Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131118 / 25.04 / All discovery apps get installed flag once I start or stop installed application #10666

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing:
See ticket, result ⬇️

Screen.Recording.2024-09-12.at.12.11.47.mov

@AlexKarpov98 AlexKarpov98 self-assigned this Sep 12, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner September 12, 2024 09:16
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team September 12, 2024 09:16
@bugclerk bugclerk changed the title NAS-131118: All discovery apps get installed flag once I start or stop installed application NAS-131118 / 25.04 / All discovery apps get installed flag once I start or stop installed application Sep 12, 2024
@bugclerk
Copy link
Contributor

@undsoft
Copy link
Collaborator

undsoft commented Sep 12, 2024

RC1 is already in code freeze.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.81%. Comparing base (25da2b4) to head (998c301).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...p/pages/apps/store/installed-apps-store.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10666   +/-   ##
=======================================
  Coverage   79.81%   79.81%           
=======================================
  Files        1562     1562           
  Lines       51355    51355           
  Branches     5847     5847           
=======================================
  Hits        40989    40989           
  Misses      10366    10366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98
Copy link
Contributor Author

RC1 is already in code freeze.

@undsoft should I use 24.10.0 ?

@undsoft
Copy link
Collaborator

undsoft commented Sep 12, 2024

Yes. I see that branches were not created yet, but they will be soon.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue no longer occurs

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants