Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130897 / 24.10-RC.1 / Add NFS tooltips (by AlexKarpov98) #10653

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 76b6ae5685e57e09e03c04ae6838fd551d3b760b

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x f2d468e5ec1caf5f4db215850bd34a464773e528

Changes:

Tooltips added

Testing:

Code review is enough.

Downstream

Affects Reasoning
Documentation Tooltips added

Original PR: #10651
Jira URL: https://ixsystems.atlassian.net/browse/NAS-130897

@undsoft undsoft marked this pull request as ready for review September 11, 2024 10:30
@undsoft undsoft requested a review from a team as a code owner September 11, 2024 10:30
@undsoft undsoft requested review from denysbutenko and removed request for a team September 11, 2024 10:30
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@undsoft undsoft enabled auto-merge (squash) September 11, 2024 10:31
@undsoft undsoft merged commit 0930f3b into stable/electriceel Sep 11, 2024
7 checks passed
@undsoft undsoft deleted the NAS-130897-24.10-RC.1 branch September 11, 2024 11:03
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@d83e091). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #10653   +/-   ##
=====================================================
  Coverage                      ?   79.66%           
=====================================================
  Files                         ?     1569           
  Lines                         ?    51291           
  Branches                      ?     5920           
=====================================================
  Hits                          ?    40860           
  Misses                        ?    10431           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants