NAS-130848 / 25.04 / Add apps stats #10620
Conversation
bugclerk
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10620 +/- ##
==========================================
+ Coverage 79.73% 79.75% +0.01%
==========================================
Files 1561 1562 +1
Lines 51295 51325 +30
Branches 5846 5846
==========================================
+ Hits 40901 40934 +33
+ Misses 10394 10391 -3 ☔ View full report in Codecov by Sentry. |
| @@ -4,13 +4,13 @@ <h4>{{ 'Network I/O' | translate }}</h4> | |||
| <div class="in-out-row"> | |||
| <span>{{ 'In' | translate }}:</span> | |||
| <span *ixWithLoadingState="stats() as stats"> | |||
| {{ stats.network.incoming | ixNetworkSpeed }} | |||
| {{ stats.networks[0].rx_bytes | ixNetworkSpeed }} | |||
There was a problem hiding this comment.
I think we may need to sum up values from all interfaces here.
There was a problem hiding this comment.
I noted this in the ticket
| <div class="cell cell-network" [matTooltip]="'Incoming / Outgoing network traffic' | translate"> | ||
| @if (stats()?.networks) { | ||
| <span> | ||
| {{ stats().networks[0].rx_bytes | ixNetworkSpeed }} |
There was a problem hiding this comment.
Commented in incorrect place. App widgets can be fixed later, but network stats need to be fixed here now.
|
This PR has been merged and conversations have been locked. |
Changes:
Add apps stats on installed apps
Testing:
Check installed apps page
Downstream