Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130956 / 25.04 / Reduce numbers of layout shifts on login page #10612

Merged
merged 16 commits into from
Sep 16, 2024

NAS-130956: PR Update

73c7ed8
Select commit
Loading
Failed to load commit list.
Merged

NAS-130956 / 25.04 / Reduce numbers of layout shifts on login page #10612

NAS-130956: PR Update
73c7ed8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 16, 2024 in 0s

79.72% (-0.07%) compared to 515e04a

View this Pull Request on Codecov

79.72% (-0.07%) compared to 515e04a

Details

Codecov Report

Attention: Patch coverage is 88.40580% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.72%. Comparing base (515e04a) to head (73c7ed8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/app/services/token-lifetime.service.ts 0.00% 3 Missing ⚠️
src/app/services/auth/auth.service.ts 60.00% 2 Missing ⚠️
.../pages/signin/signin-form/signin-form.component.ts 90.00% 1 Missing ⚠️
src/app/pages/signin/signin.component.ts 92.85% 1 Missing ⚠️
src/app/services/token-last-used.service.ts 96.87% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10612      +/-   ##
==========================================
- Coverage   79.78%   79.72%   -0.07%     
==========================================
  Files        1563     1564       +1     
  Lines       51483    51521      +38     
  Branches     5852     5856       +4     
==========================================
- Hits        41075    41073       -2     
- Misses      10408    10448      +40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov