Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129855 / 25.04 / Update default widgets layout #10577

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

denysbutenko
Copy link
Member

Changes:

image
image
image

Testing:

Check screenshots and dashboard on a fresh install.

Downstream

Affects Reasoning
Documentation Dashboard screenshots needs to be updated

@denysbutenko denysbutenko requested a review from a team as a code owner August 28, 2024 15:38
@denysbutenko denysbutenko requested review from undsoft and removed request for a team August 28, 2024 15:38
@bugclerk bugclerk changed the title NAS-129855: Update default widgets layout NAS-129855 / 25.04 / Update default widgets layout Aug 28, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.70%. Comparing base (3919f49) to head (98c92b7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10577   +/-   ##
=======================================
  Coverage   79.69%   79.70%           
=======================================
  Files        1560     1560           
  Lines       50851    50855    +4     
  Branches     5821     5822    +1     
=======================================
+ Hits        40525    40532    +7     
+ Misses      10326    10323    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@denysbutenko denysbutenko merged commit 45ae3cb into master Aug 29, 2024
9 checks passed
@denysbutenko denysbutenko deleted the NAS-129855 branch August 29, 2024 11:59
@bugclerk
Copy link
Contributor

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-129855 is targeted to the following versions which have not received their corresponding PRs: 24.10-RC.1

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 29, 2024
@denysbutenko denysbutenko added the backport-24.10-RC.1 Electric Eel RC1 label Aug 29, 2024
@denysbutenko
Copy link
Member Author

backport

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants