Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130588 / 24.10-RC.1 / Docker configuration - install nvidia drivers (by AlexKarpov98) #10567

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 9a2dd97c263e946e93575fc77751166c83803a36
git cherry-pick -x ff58e77f75306f7747b18dbb499aee10381aa22a
git cherry-pick -x 88919815d8cb01906b46f68ba7e2e87e89cefe1e
git cherry-pick -x 9d9013b134cfed094896451e05b7ea03822525ae
git cherry-pick -x d003e934d9bc5fe5734dc1173e66e37c200eafa0

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 8c167891c35bf703859aa17d855cd4271acf38db

Changes:
Settings button is now Configuration / Train Settings - Settings

Testing:
You can mock API call in docker.store.ts to always see Install NDIVIA Drivers checkbox.
Please check ticket description and comments.

Install NDIVIA Drivers checkbox should be visible when docker.lacks_nvidia_drivers is true OR when it is checked (so the user can uncheck it).

mock it like:

  private getDockerLacksNvidiaDrivers(): Observable<boolean> {
    // return this.ws.call('docker.lacks_nvidia_drivers');
    return of(true);
  }

Result: (fast forward to not wait that long)

Screen.Recording.2024-08-26.at.15.44.09.mov

Downstream

Affects Reasoning
Documentation New functionality, buttons text updates

Original PR: #10557
Jira URL: https://ixsystems.atlassian.net/browse/NAS-130588

…10557)

* NAS-130588: Docker configuration - install nvidia drivers

* NAS-130588: Docker configuration - install nvidia drivers

* NAS-130588: PR Update

* NAS-130588: PR Update

(cherry picked from commit 8c16789)
@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review August 28, 2024 08:06
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner August 28, 2024 08:06
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team August 28, 2024 08:06
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) August 28, 2024 08:07
@AlexKarpov98 AlexKarpov98 merged commit 41de1ae into stable/electriceel Aug 28, 2024
7 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-130588-24.10-RC.1 branch August 28, 2024 08:38
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@4c14807). Learn more about missing BASE report.

Files Patch % Lines
src/app/pages/apps/store/docker.store.ts 18.18% 9 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #10567   +/-   ##
=====================================================
  Coverage                      ?   79.62%           
=====================================================
  Files                         ?     1565           
  Lines                         ?    51145           
  Branches                      ?     5896           
=====================================================
  Hits                          ?    40724           
  Misses                        ?    10421           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants