Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129013 / 25.04 / Skip disabled buttons for changes by directive #10523

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

denysbutenko
Copy link
Member

Changes:

Fix Initiate Failover button on main dashboard (and other buttons too).

Testing:

On HA system. Disable Failover. Open main dashboard-ensure the Initiate Failover button is disabled. Click Configure button to edit mode. Save changes. Ensure Initiate Failover button still disabled.

@denysbutenko denysbutenko requested a review from a team as a code owner August 22, 2024 06:24
@denysbutenko denysbutenko requested review from bvasilenko and removed request for a team August 22, 2024 06:24
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-129013: Skip disabled buttons for changes by directive NAS-129013 / 25.04 / Skip disabled buttons for changes by directive Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.54%. Comparing base (ce029e7) to head (546ad08).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10523      +/-   ##
==========================================
- Coverage   79.54%   79.54%   -0.01%     
==========================================
  Files        1560     1560              
  Lines       50781    50773       -8     
  Branches     5815     5813       -2     
==========================================
- Hits        40396    40388       -8     
  Misses      10385    10385              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@denysbutenko denysbutenko merged commit a5e774f into master Aug 26, 2024
9 checks passed
@denysbutenko denysbutenko deleted the NAS-129013 branch August 26, 2024 04:30
@bugclerk
Copy link
Contributor

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-129013 is targeted to the following versions which have not received their corresponding PRs: 24.10-RC.1

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 26, 2024
@denysbutenko
Copy link
Member Author

backport

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants