Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130474 / 24.10-RC.1 / UI should expose option to skip ACL traverse validation i… #10520

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Aug 21, 2024

Changes:

See ticket.

Testing:

Create a DS connected machine and test new checkbox.

Downstream

Affects Reasoning
Documentation New setting in ACL form.

…n the ACL form
@undsoft undsoft requested a review from a team as a code owner August 21, 2024 14:22
@undsoft undsoft requested review from AlexKarpov98 and removed request for a team August 21, 2024 14:22
@bugclerk bugclerk changed the title NAS-130474: UI should expose option to skip ACL traverse validation i… NAS-130474 / 24.10-RC.1 / UI should expose option to skip ACL traverse validation i… Aug 21, 2024
@bugclerk
Copy link
Contributor

@undsoft undsoft added the backport-25.04-RC.1 Fangtooth RC1 label Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@af046c5). Learn more about missing BASE report.

Files Patch % Lines
...ave-controls/acl-editor-save-controls.component.ts 97.43% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #10520   +/-   ##
=====================================================
  Coverage                      ?   79.61%           
=====================================================
  Files                         ?     1565           
  Lines                         ?    51109           
  Branches                      ?     5888           
=====================================================
  Hits                          ?    40691           
  Misses                        ?    10418           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new option is there 👌

Screenshot 2024-08-22 at 17 18 03

@undsoft undsoft merged commit 55a6ec7 into stable/electriceel Aug 23, 2024
9 checks passed
@undsoft undsoft deleted the NAS-130474 branch August 23, 2024 08:16
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants