Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130604 / 24.10-RC.1 / CPU model widget (by AlexKarpov98) #10482

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

bugclerk
Copy link
Contributor

Changes:

New widget.

Testing:
See ticket.

Screenshot 2024-08-15 at 09 42 50

Downstream

Affects Reasoning
Documentation New widget.

Original PR: #10470
Jira URL: https://ixsystems.atlassian.net/browse/NAS-130604

(cherry picked from commit b8b6b4c)
(cherry picked from commit 91646e0)
(cherry picked from commit 48c5549)
@bugclerk bugclerk requested a review from a team as a code owner August 16, 2024 11:32
@bugclerk bugclerk requested review from RehanY147 and removed request for a team August 16, 2024 11:32
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@0a9a5c4). Learn more about missing BASE report.

Files Patch % Lines
...ges/dashboard/services/widget-resources.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #10482   +/-   ##
=====================================================
  Coverage                      ?   79.43%           
=====================================================
  Files                         ?     1564           
  Lines                         ?    51108           
  Branches                      ?     5888           
=====================================================
  Hits                          ?    40600           
  Misses                        ?    10508           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported

@undsoft undsoft merged commit c87100a into stable/electriceel Aug 16, 2024
7 checks passed
@undsoft undsoft deleted the NAS-130604-24.10-RC.1 branch August 16, 2024 13:15
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants