Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130596 / 25.04 / Reword application use warning message #10476

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Changes:

Text changes.

Testing:
See ticket

Downstream

Affects Reasoning
Documentation Text changes.

@AlexKarpov98 AlexKarpov98 self-assigned this Aug 15, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner August 15, 2024 11:41
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team August 15, 2024 11:41
@bugclerk bugclerk changed the title NAS-130596: Reword application use warning message NAS-130596 / 25.04 / Reword application use warning message Aug 15, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (014b60d) to head (d0914d7).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10476      +/-   ##
==========================================
+ Coverage   79.54%   79.56%   +0.01%     
==========================================
  Files        1562     1560       -2     
  Lines       51035    51011      -24     
  Branches     5883     5880       -3     
==========================================
- Hits        40594    40585       -9     
+ Misses      10441    10426      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Снимок экрана 2024-08-15 в 15 45 38 Would be better to make it two paragraphs.

@AlexKarpov98
Copy link
Contributor Author

updated:
Screenshot 2024-08-15 at 17 52 15

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) August 15, 2024 14:52
@AlexKarpov98 AlexKarpov98 disabled auto-merge August 15, 2024 15:09
@AlexKarpov98 AlexKarpov98 merged commit eab0145 into master Aug 16, 2024
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-130596 branch August 16, 2024 10:50
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants