Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130582 / 25.04 / Remove old dashboard and enclosure UI (by undsoft) #10453

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

bugclerk
Copy link
Contributor

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 01c430dca65b1f913d89da89e72864ea0be4c07d

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x 169213343f70bf600c77c93eda7eef89cde8ebd7

Changes:

Removes old dashboard and enclosure UI.

Testing:

Code review is enough.

Downstream

Affects Reasoning
Documentation Removes old dashboard and enclosure UI.

Original PR: #10451
Jira URL: https://ixsystems.atlassian.net/browse/NAS-130582

@undsoft undsoft marked this pull request as ready for review August 13, 2024 13:18
@undsoft undsoft requested a review from a team as a code owner August 13, 2024 13:18
@undsoft undsoft requested review from denysbutenko and removed request for a team August 13, 2024 13:18
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ported.

@undsoft undsoft enabled auto-merge (squash) August 13, 2024 13:19
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.30%. Comparing base (7e8d0e1) to head (f9a42f7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10453      +/-   ##
==========================================
+ Coverage   76.98%   79.30%   +2.32%     
==========================================
  Files        1622     1562      -60     
  Lines       55001    51079    -3922     
  Branches     6460     5884     -576     
==========================================
- Hits        42341    40507    -1834     
+ Misses      12660    10572    -2088     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit 8fad7dc into master Aug 13, 2024
9 checks passed
@undsoft undsoft deleted the NAS-130582-25.04 branch August 13, 2024 13:50
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants