Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130365 / 25.04 / Improve Add Alert Service > Level Tooltip #10444

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Changes:

Tooltip text change.

Testing:
Code review is enough.

Affects Reasoning
Documentation Tooltip text change.

@AlexKarpov98 AlexKarpov98 self-assigned this Aug 13, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner August 13, 2024 07:50
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team August 13, 2024 07:50
@bugclerk bugclerk changed the title NAS-130365: Improve Add Alert Service > Level Tooltip NAS-130365 / 25.04 / Improve Add Alert Service > Level Tooltip Aug 13, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.97%. Comparing base (8608c79) to head (09b0b7d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10444   +/-   ##
=======================================
  Coverage   76.97%   76.97%           
=======================================
  Files        1622     1622           
  Lines       55001    55001           
  Branches     6462     6462           
=======================================
  Hits        42339    42339           
  Misses      12662    12662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@AlexKarpov98 AlexKarpov98 merged commit 2e57c99 into master Aug 13, 2024
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-130365 branch August 13, 2024 10:31
@bugclerk
Copy link
Contributor

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-130365 is targeted to the following versions which have not received their corresponding PRs: 24.10-RC.1

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 13, 2024
@truenas truenas deleted a comment from bugclerk Aug 13, 2024
@truenas truenas deleted a comment from bugclerk Aug 13, 2024
@AlexKarpov98
Copy link
Contributor Author

backport

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants